Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MCP (Model Context Protocol) tooling infrastructure by removing the environment_id parameter throughout the codebase. The changes simplify the API surface by eliminating environment-specific configuration, consolidating all environment logic to be derived from environment variables rather than being passed as explicit parameters.
Key changes:
- Removed
environment_idparameter from all tool server configuration and registration methods - Simplified URL construction logic to use a unified endpoint pattern without environment path segments
- Removed
ENVIRONMENT_IDheader constant as it's no longer needed for HTTP requests
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utility.py | Simplified URL building functions by removing environment_id parameters and conditional logic |
| constants.py | Removed ENVIRONMENT_ID header constant that is no longer used |
| mcp_tool_server_configuration_service.py | Removed environment_id parameter from all methods and updated validation logic |
| mcp_tool_registration_service.py (semantickernel) | Removed environment_id parameter and associated header from tool registration |
| mcp_tool_registration_service.py (openai) | Removed environment_id parameter and header from OpenAI agent tool registration |
| mcp_tool_registration_service.py (azureaifoundry) | Removed environment_id parameter from Azure AI Foundry integration |
| README.md files | Updated code examples to remove environment_id parameter from method calls |
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27
- The imports reference 'microsoft_kairo' which should be replaced with the appropriate package name. This appears to be a legacy reference that needs to be updated to match the current project structure (e.g., 'microsoft_agents_a365').
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants
Environment id should no longer need to be passed - service layer will handle routing to MCC environment.