Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add msr::airlib::EarthUtils::GeodeticToNed method #3829

Open
zimmy87 opened this issue Jun 25, 2021 · 2 comments
Open

add msr::airlib::EarthUtils::GeodeticToNed method #3829

zimmy87 opened this issue Jun 25, 2021 · 2 comments

Comments

@zimmy87
Copy link
Contributor

zimmy87 commented Jun 25, 2021

What feature are you suggesting?

Overview:

Right now there is a msr::airlib::EarthUtils::GeodeticToNedFast for converting GeoPoints to NED coordinates, but the algorithm implemented is a approximate that can result in errors of up to 10km. There is a corresponding method for converting the opposite way, msr::airlib::EarthUtils::nedToGeodeticFast, that has a non-fast version, but we don't yet have a non-fast version of msr::airlib::EarthUtils::GeodeticToNedFast.

Smaller Details:

Nature of Request:

  • Addition

Why would this feature be useful?

This would remove any possible error in the WorldSimApi::testLineOfSightBetweenPoints API

@rajat2004
Copy link
Contributor

There's a file GeodeticConverter.hpp, it was discussed a bit in #3364 (comment) and later as well. I'll try to bring in the changes I made and see if this turns out to be useful, currently it's unused

@zimmy87
Copy link
Contributor Author

zimmy87 commented Jun 29, 2021

Ah I forgot about that file, I've updated calls to msr::airlib::EarthUtils::GeodeticToNedFast with calls to msr::airlib::GeodeticConverter::geodetic2Ned in #3810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants