move line-of-sight APIs to WorldSimApi #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving testLineOfSightBetweenPoints and getWorldExtents to WorldSimApi which is a more appropriate location for these APIs
rajat2004
reviewed
Jun 23, 2021
fixing clang-format check and various items from code review
rajat2004
reviewed
Jun 25, 2021
|
There was a CR feedback item about using a non-fast version of the msr::airlib::EarthUtils::GeodeticToNedFast method. Since we don't have a current implementation of a method like this, I suggest we opt for a feature request to handle the implementation separately: #3829 |
|
Thanks @zimmy87! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
About
moving testLineOfSightBetweenPoints and getWorldExtents to WorldSimApi which is a more appropriate location for these APIs
How Has This Been Tested?
built and launched with SimpleFlight for sanity check
Screenshots (if appropriate):