-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unity settings file #2303
Fix unity settings file #2303
Conversation
|
Hey @wolf843, does this also fix the problem of an extra I have opened another PR with some other improvements to Unity build (#2328), and noticed this problem during that |
} | ||
|
||
// Verify SettingsVersion is greater than 1.2 | ||
if (SettingsVersion != 1.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be <
here
I think the problem still persists, since the GetAirSimSettingsFileName() is the same as in the older InitializeAirsim.cs Could be mistaken, please correct me if that's the case |
@madratman I think the best way to get the settings fixed would be to do piecewise PRs or atleast smaller commits, will make it much easier to review and test |
closed due to license agreement not being signed and unanswered old CR feedback |
test pull