ROS: Use the same settings as AirSim #3536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3530
Fixes: #3464
Fixes: #2415
Others: #2365, #2009
About
This adds an API to get the settings text which is being used by AirSim. The API is then used by the ROS wrapper to fetch the settings text and uses it to instantiate its own settings.
This felt like the cleaner way to fix the problem at its root, it'll avoid requiring the same logic to search for the settings.json file, and now doesn't matter if Airsim and the ROS wrapper are running in different machines.
Any suggestions on a better way to implement this would be great!
How Has This Been Tested?
Screenshots (if appropriate):