Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Octo X config #3653

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Added Octo X config #3653

merged 4 commits into from
Jun 10, 2021

Conversation

aaqibismail
Copy link
Contributor

Fixes: #

#3593

About

Added an Octo X rotor configuration for PX4 devices. The rotor poses were calculated according to NED's left hand rule.

How Has This Been Tested?

I changed the model in settings.json to "Octocopter" and adjusted the SITL none_iris PX4 target to use an octo_x mixer file. I tested with both a controller and a python script and ensured that not only did it fly smoothly, but that there were 8 actuator outputs.

Screenshots (if appropriate):

@ghost
Copy link

ghost commented May 3, 2021

CLA assistant check
All CLA requirements met.

@zimmy87
Copy link
Contributor

zimmy87 commented Jun 3, 2021

It seems that your PR is failing the clang-format check. Please follow these steps to resolve this:

  1. check out your pull request
  2. run git checkout master .clang-format in your repo's root folder
  3. if you don't have npm installed, download it from https://www.npmjs.com/get-npm
  4. run npm install -g clang-format
  5. run clang-format -i path/to/file for each failing file (failing files can be found in the details for the clang-format check)
  6. run git add -u to track all style changes
  7. run git commit -am "apply style from clang-format"
  8. run git merge master
  9. resolve other non-style conflicts if you have any
  10. push changes

Thanks for helping us with these style changes!

@zimmy87
Copy link
Contributor

zimmy87 commented Jun 8, 2021

Hi @aaqibism! Were you testing this PR with a specific mesh for your octocopter? If so, is this mesh publicly available somewhere?

@aaqibismail
Copy link
Contributor Author

Hi @aaqibism! Were you testing this PR with a specific mesh for your octocopter? If so, is this mesh publicly available somewhere?

I tested with the default quad mesh.

@zimmy87
Copy link
Contributor

zimmy87 commented Jun 10, 2021

Thanks for the contribution @aaqibism! Tested with commander and python script; looks to be working for me so I am moving ahead with merge.

@zimmy87 zimmy87 merged commit 4206ac5 into microsoft:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants