keep CollisionInfo.has_collided flag set until simGetCollisionInfo called #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new method added in PawnSimApi to both return collision info as well as reset the has_collided flag
|
Thanks, @zimmy87! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1004
About
This adds a new method to PawnSimApi called getCollisionInfoAndReset() which both returns collision info as well as reset the has_collided flag. The old behavior for resetting CollisionInfo.has_collided after every clock tick has been removed and simGetCollisionInfo now calls getCollisionInfoAndReset(), which means this method will return whether any collision has occurred since last call to simGetCollisionInfo instead of only within the last clock tick.
How Has This Been Tested?
Collisions were tested in the Blocks environment with the EnableCollisionPassthrogh parameter set to both true and false.
Screenshots (if appropriate):