Look for settings.json in multiple places #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore documents folder Untabify Fix whitespace in .hpp files
ahorn42
added a commit
to ahorn42/AirSim
that referenced
this pull request
May 6, 2020
…ument as a path in addition to passing its content. Also updated documentation, which did not list the other loading possibilities added with microsoft#715.
ahorn42
added a commit
to ahorn42/AirSim
that referenced
this pull request
May 6, 2020
…ument as a path in addition to passing its content. Also updated documentation, which did not list the other loading possibilities added with microsoft#715.
madratman
added a commit
that referenced
this pull request
Jul 24, 2020
…ument (#2668) * Allows to pass the settings.json file location via the --settings argument as a path in addition to passing its content. Also updated documentation, which did not list the other loading possibilities added with #715. * add linux example to doc Co-authored-by: madratman <ratneshmadaan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, AirSim looks for the settings.json in the user's documents folder. As detailed in this issue, this can cause problems in some situations. Introduce two new ways of specifying the settings file (listed in the order of priority):
> AirSimApp.exe my_awesome_map --settings "{\"SettingsVersion\": 1.0, \"SimMode\": \"Car\"}"If the --settings flag is not specified and the settings.json does not exist in the executable directory, then the settings.json in the user's documents directory is used. If it does not exist there, then AirSim will attempt to create the settings.json in the documents directory (as before).