Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Enable optional customized http.Client for transmitter #41

Closed
wmdave opened this issue Aug 31, 2019 · 1 comment
Closed

Comments

@wmdave
Copy link
Contributor

wmdave commented Aug 31, 2019

I'm building an application which leverages the app insights go client and, in order to run the resulting application in a minimal container (i.e. one without an OS CA certificate store), I need the ability to programmatically include trusted CA certificates in the transmitter's http.Client.

To enable this, I was thinking of adding the option to include a *http.Client option in TelemetryConfig which can then be leveraged during Transmit to call the app insights endpoint. If the value of the TelemetryConfig.Client option is nil, the call to newTransmitter would substitute the http.DefaultClient automatically.

jjjordanmsft added a commit that referenced this issue May 1, 2020
Issue #41 - Optional customized http.Client for transmitter
@jjjordanmsft
Copy link
Contributor

This was merged. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants