-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] SDK LOAD Failure reporting not working #2027
Comments
Yep, go for it |
MSNev
added a commit
that referenced
this issue
Apr 6, 2023
MSNev
added a commit
that referenced
this issue
Apr 7, 2023
MSNev
added a commit
that referenced
this issue
Apr 7, 2023
MSNev
added a commit
that referenced
this issue
Apr 7, 2023
MSNev
added a commit
that referenced
this issue
Apr 7, 2023
MSNev
added a commit
that referenced
this issue
Apr 7, 2023
MSNev
added a commit
that referenced
this issue
Apr 10, 2023
MSNev
added a commit
that referenced
this issue
Apr 11, 2023
MSNev
added
waiting - CDN deployment
released - NPM
and removed
fixed - waiting release
PR Committed and waiting deployment
labels
Apr 11, 2023
MSNev
added a commit
that referenced
this issue
Apr 12, 2023
* [BUG] The documentation for enableDebug is incorrect, it should reference enableDebugExceptions #2014 (#2022) * [BUG] SDK LOAD Failure reporting not working #2027 (#2038) * Add a simple interface to enable custom buffer storage solutions #1419 (#2037) This can be used like: ``` const appInsights = new ApplicationInsights({ config: { enableSessionStorageBuffer: true, bufferOverride: { getItem: (logger, key) => localStorage.getItem(key), setItem: (logger, key, value) => localStorage.setItem(key, value), } } }); ``` Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com> * [Master] Add readme documentation for IStorageBuffer (#2045) * [Release] Increase version to 2.8.12 (#2046) --------- Co-authored-by: Philip Peitsch <philip.peitsch@gmail.com>
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description/Screenshot
SDK LOAD Failure is not being sent successfully with instrumentation key errors as response.
This is all due to a mix of issues in the actual snippet code but also the snippet as presented in the README: see additional context below.
Steps to Reproduce
connectionString: "InstrumentationKey=[KEY];IngestionEndpoint=[ENDPOINT];LiveEndpoint=[LIVEENDPOINT]"
iKey
of payload containing the entire connection string and not just the instrumentation key.Expected behavior
Connection string to be parsed correctly and exception being tracked successfully.
Additional context
Using connection string only has not been working for quite some time due to a mistake in the snippet:
ApplicationInsights-JS/AISKU/snippet/snippet.js
Lines 37 to 44 in 5d7e042
ApplicationInsights-JS/AISKU/snippet/snippet.js
Lines 75 to 76 in 5d7e042
The above issue used to possible to be worked around by also providing an instrumenctionKey in the snippet config that then would be used instead, but with the snippet from the current readme this no longer works due:
D
in the snippet frominstrumentationKey
toconnectionString
.I am willing to post a PR if you are open for that.
The text was updated successfully, but these errors were encountered: