Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] test version conflict and wirte documentation #2123

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

siyuniu-ms
Copy link
Contributor

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@MSNev
Copy link
Collaborator

MSNev commented Aug 3, 2023

Lets move this to tests / Manual as it's not really an example that we want people to use.

The code scanning issues look like they are all from ai.test.js (v1 of the SDK), so lets just mark those as won't fix with a description that this is the previously published version that we are using for testing only.

@siyuniu-ms siyuniu-ms merged commit f45ad22 into main Aug 7, 2023
7 checks passed
@siyuniu-ms siyuniu-ms deleted the siyu/testVersionConflict branch November 20, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants