[main] allow empty string as first parameter to fetch #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorupp
commented
Sep 18, 2023
| @@ -1628,6 +1628,124 @@ export class AjaxTests extends AITestClass { | |||
| }] | |||
| }); | |||
|
|
|||
| this.testCaseAsync({ | |||
There was a problem hiding this comment.
I cloned the two test cases above this that were testing for null/undefined, but I didn't completely understand what all of the setup/checks were that were necessary.
jorupp
commented
Sep 18, 2023
extensions/applicationinsights-dependencies-js/Tests/Unit/src/ajax.tests.ts
Show resolved
Hide resolved
jorupp
commented
Sep 18, 2023
extensions/applicationinsights-dependencies-js/Tests/Unit/src/ajax.tests.ts
Show resolved
Hide resolved
|
@jorupp can you please review and sign the CLA (if acceptable). I've already backported and committed your changes to |
The guy from our legal team hasn't gotten back to me yet - I'm planning to bug him again in the morning (US CT), but I don't expect I'll have any trouble getting him to sign off. |
|
@microsoft-github-policy-service agree company="Rightpoint" |
MSNev
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow calling
fetchwith an empty string as the first parameter.Fixes #2419.