[main] enable auto doc generation #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuniu-ms
had a problem deploying
to
github-pages
GitHub Actions
Failure
MSNev
reviewed
Sep 11, 2024
| @@ -41,6 +41,8 @@ jobs: | |||
| - run: node common/scripts/install-run-rush.js install | |||
| - run: npm run build --verbose | |||
| timeout-minutes: 20 | |||
| - name: doc generate | |||
There was a problem hiding this comment.
Oh, I see...
So at the point that this action "runs" which should be triggered by the "checkin" (please correct me if I'm wrong) we not only "decorate" the pages here but actually "generate them -- nice!
There was a problem hiding this comment.
FYI - in github "Authorization" of an action based on the branch name is at the top of the file
on:
# Runs on pushes targeting the default branch
push:
branches: ["main"]and is not part of the "Internal" authorization process
There was a problem hiding this comment.
this seems to be the branches that could auto trigger the run, but didn't give the access of publish the doc
MSNev
approved these changes
Sep 11, 2024
siyuniu-ms
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.