added check for open port before creating test server. #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaval24
suggested changes
Nov 10, 2018
web/src/test/java/com/microsoft/applicationinsights/web/utils/JettyTestServer.java
Show resolved
Hide resolved
dhaval24
approved these changes
Nov 10, 2018
| private int Min = 1050; | ||
| private int Max = 15000; | ||
| private int portNumber = Min + (int)(Math.random() * ((Max - Min) + 1)); | ||
| private final int Min = 1050; |
There was a problem hiding this comment.
@littleaj can you please adhere to camelCase for varable names here. I know you didn't made this variable but since you touched this part of the code better that we can clean up if possible.
|
|
||
| public JettyTestServer() { | ||
| // try 256 times for ports | ||
| int initialPortNumber = Min + (int)(Math.random() * ((Max - Min) + 1)); |
There was a problem hiding this comment.
A standard way / best practice in java to get random integer within the range is this:
import java.util.concurrent.ThreadLocalRandom;
// nextInt is normally exclusive of the top value,
// so add 1 to make it inclusive
int randomNum = ThreadLocalRandom.current().nextInt(min, max + 1);
We don't need to reproduce the results, so seed of random doesn't really matter.
@littleaj it would be great if you can change this one as bonus!
There was a problem hiding this comment.
Since this is test code, so I'm not really worried about this.
There was a problem hiding this comment.
Cool :) no worries. Please proceed with merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests a bit more reliable.