Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configuration with distro #215

Merged
merged 8 commits into from
Jan 11, 2023
Merged

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 5, 2023

In order to encapsulate custom azure components and configuration, the distro will now allow users the ability to instantiate everything that is needed for an opentelemetry workflow to azure monitor, with the ability to configure the components using params. This will be done using a new distro api configure_opentelemetry as shown below:

from opentelemetry import trace
from azure.monitor.opentelemetry.distro import configure_opentelemetry

configure_opentelemetry()

tracer = trace.get_tracer(__name__)

with tracer.start_as_current_span("hello2"):
    print("Hello, World!")

input()

Things to note:

  1. This PR adds only the barebones skeleton, and only allows manual configuration of some variables (service.name and such)
  2. Autoinstrumentation capabilities remain unchanged. Autoinstrumentation workflow will be refactored to use common code in the added distro api but will remain a TODO.
  3. Everything in this PR is a proposal and subject to discussion/change. The idea is to create a bunch of working customer scenarios that will show the value of the distro api.

@lzchen lzchen requested review from a team and jeremydvoss as code owners January 5, 2023 23:24
@lzchen lzchen merged commit 0e3bf6a into microsoft:main Jan 11, 2023
@lzchen lzchen deleted the configure branch January 11, 2023 00:02
This was referenced Jan 19, 2023
@jeremydvoss jeremydvoss mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants