Exporter 1.0.0b14 #295
Exporter 1.0.0b14 #295
Conversation
| @@ -14,10 +14,10 @@ | |||
| SAMPLING_RATIO_ARG, | |||
| ) | |||
| from azure.monitor.opentelemetry._types import ConfigurationValue | |||
| from azure.monitor.opentelemetry._vendor.v0_38b0.opentelemetry.instrumentation.dependencies import ( | |||
| from azure.monitor.opentelemetry._vendor.v0_39b0.opentelemetry.instrumentation.dependencies import ( | |||
There was a problem hiding this comment.
Did we release a version of the distro which vendored v0.38b0 before?
There was a problem hiding this comment.
That's fine that we didn't. I'm just wondering if, before we go GA, should we have one folder that we keep updating, or should we add a new vendored folder for each version of the instrumentations? i.e. have a vendor folder for 0.38b0 and one for 0.39b0 and so on for every release
There was a problem hiding this comment.
I think one folder is ultimately better. Far less unused code. Easier to notice iterations. But if there's ever a breaking bug where we need to keep more than one, we can.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| __version__ = "0.38b0" |
There was a problem hiding this comment.
We should probably remove the version files for all instrumentations and just hard code a constant in each of the init.py
There was a problem hiding this comment.
What would really be the purpose of this?
There was a problem hiding this comment.
We don't want to have unnecessary files in our vendored folders since these will be every growing. If we can just keep everything within init.py that would be ideal. version.py is only really used in README files anyways.
There was a problem hiding this comment.
Confirmed version is used in the vendored code.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| __version__ = "0.38b0" |
There was a problem hiding this comment.
Also is package.py used for anything? Can we remove all of them?
There was a problem hiding this comment.
Package.py can be removed since I had to use a workaround for the optional dependencies anyways.
There was a problem hiding this comment.
Put back in because the current flow is needed by base distro. Removing is possible, but not without a good amount of effort.
jeremydvoss
force-pushed
the
exporter-1.0.0b14
branch
2 times, most recently
from
865a994
to
b5f44bf
Compare
jeremydvoss
force-pushed
the
exporter-1.0.0b14
branch
from
147422b
to
db5b43b
Compare
Updating to latest version of the exporter and using OTel 1.18/0.39