Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor 0.40 #309

Closed
wants to merge 23 commits into from
Closed

Vendor 0.40 #309

wants to merge 23 commits into from

Conversation

jeremydvoss
Copy link
Member

No description provided.

Default span name is the HTTP method and URL path, or just the method.
https://github.com/open-telemetry/opentelemetry-specification/pull/3165
https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/http/#name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a potential breaking change:
open-telemetry/opentelemetry-python-contrib#1759

Copy link
Member Author

@jeremydvoss jeremydvoss Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking results of requests and dependencies. All columns match. So, I think we can consider this change to be okay.
Matching requests.csv
Matching dependencies.csv

@jeremydvoss jeremydvoss marked this pull request as ready for review July 20, 2023 22:46
@jeremydvoss jeremydvoss requested review from a team and lzchen as code owners July 20, 2023 22:46
@lzchen
Copy link
Contributor

lzchen commented Jul 21, 2023

Any reason we want to support 0.40b0 so soon? Are you planning on vendoring everytime there's a new release of the instrumentations?

@jeremydvoss
Copy link
Member Author

Any reason we want to support 0.40b0 so soon? Are you planning on vendoring everytime there's a new release of the instrumentations?

I guess being behind on vendoring doesn't block Cxs like being behind on the sdk/api. So, we can hold off.

@lzchen
Copy link
Contributor

lzchen commented Jul 25, 2023

@jeremydvoss

I think the key is to have an understanding between us and the customers. Should we only update it when there's a release, or should it be update only if there are big/breaking/feature changes? I think we can start with the latter and if there is sufficient demand for latest features we can change our process.

@jeremydvoss
Copy link
Member Author

jeremydvoss commented Aug 18, 2023

Azure SDK Version: Azure/azure-sdk-for-python#31719

@jeremydvoss
Copy link
Member Author

Closing in favor of unvendoring: Azure/azure-sdk-for-python#31744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants