This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 123
Make W3C Correlation default and leverage native W3C support from new System.Diagnostics.DiagnosticSource Activity #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f1427a.
…n 7.2 which is required for new Activity span types.
lmolkova
approved these changes
Aug 27, 2019
Merged
@reyang Please have a look. |
reyang
reviewed
Aug 30, 2019
@@ -63,4 +53,4 @@ steps: | |||
inputs: | |||
PathtoPublish: "$(build.artifactstagingdirectory)" | |||
ArtifactName: "drop" | |||
ArtifactType: "Container" | |||
ArtifactType: "Container" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, empty line before EOF
reyang
reviewed
Aug 30, 2019
@@ -1,5 +1,10 @@ | |||
# Changelog | |||
|
|||
## Version 2.8.0-beta3 | |||
- [Make W3C Correlation default and leverage native W3C support from Activity.](https://github.com/microsoft/ApplicationInsights-aspnetcore/pull/958) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be precise, this is "W3C TraceContext" instead of "W3C Correlation".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AspNetCore RequestCollection specific changes, followup for the base SDK changes introduced in the PR:
microsoft/ApplicationInsights-dotnet#1193
Also Fixes:
#956
#900
To do:
3.XX support (separate PR)
(replaying #958 as it had to be reverted temporarily)