Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies to unsupported and end of life nuget packages and frameworks #2850

Open
antymon4o opened this issue Feb 28, 2024 · 2 comments
Open

Comments

@antymon4o
Copy link

Application Insights projects target frameworks net452 and net46 that are now not supported any more.
List of currently supported framework versions can be seen at: https://dotnet.microsoft.com/en-us/learn/dotnet/what-is-dotnet-framework.

Additionally, the project Microsoft.ApplicationInsights.AspNetCore has a dependency on packages Microsoft.AspNetCore.Http and Microsoft.AspNetCore.Hosting that are deprecated. Not only these packages are deprecated, but the packages that these packages depend are also deprecated.
This brings the implication that when some project depends on Microsoft.ApplicationInsights.AspNetCore version 2.22.0, then this project also gets the dependencies to packages that are deprecated and are no longer maintained.

The proposed solution for the first issue is to remove the unsupported targeted frameworks.
For the deprecated AspNetCore packages, the proposal is to migrate the reference from nuget package to framework reference. This also requires a pop-up in the targeted framework from netstandard2.0 to net6.0.

antymon4o added a commit to antymon4o/ApplicationInsights-dotnet that referenced this issue Mar 5, 2024
…ported microsoft#2850

use frameworkreference for Microsoft.AspNetCore.App instead of icrosoft.AspNetCore.* nuget packages, because they are now deprecated and end of life.
@MichaCo
Copy link
Contributor

MichaCo commented Mar 12, 2024

Totally agree, but this is probably a duplicate of #2811

@antymon4o
Copy link
Author

Yes, it seems so.
I have already proposed a solution for these issues. The PR is waiting to be reviewed.
I hope someone from the team will be able to look at it and after if some tunings are required, the issues can be resolved.

antymon4o added a commit to antymon4o/ApplicationInsights-dotnet that referenced this issue Mar 15, 2024
…net6.0

change conditional compilation expressions #if NET452 to #if NETFRAMEWORK

microsoft#2850
antymon4o added a commit to antymon4o/ApplicationInsights-dotnet that referenced this issue Mar 15, 2024
antymon4o added a commit to antymon4o/ApplicationInsights-dotnet that referenced this issue Mar 15, 2024
…e specifics in behavior coded in classes in project

In TelemetryChannel.ApplicationFolderProvider add #if NETFRAMEWORK in IsWindowsOperatingSystem method.

microsoft#2850
antymon4o added a commit to antymon4o/ApplicationInsights-dotnet that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants