Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RouteData not setted in ASP core 3.0 #1318

Merged
merged 4 commits into from
Nov 22, 2019

Conversation

illay1994
Copy link

#1316 - Fixed problem with read HttpContext on "Microsoft.AspNetCore.Mvc.BeforeAction" event

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…pNetCore.Mvc.BeforeAction" event
Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!.

More than the bug, this exposed lack of 3.0 test which would have caught this. We added 3.0 test, but it was doing minimal validation. Will need to migrate all 2.0 tests to 3.0. (separate from this PR ofcourse)

@cijothomas
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimothyMothra
Copy link
Member

@illay1994 Can you please update Changelog.md under the VNext section?

@TimothyMothra
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimothyMothra
Copy link
Member

We're going to merge a larger PR first and then merge this one tonight or tomorrow morning.

@TimothyMothra
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimothyMothra TimothyMothra merged commit 6949caa into microsoft:develop Nov 22, 2019
@TimothyMothra
Copy link
Member

@illay1994 We published 2.12-Beta4 this morning including your changes! :)

@cijothomas
Copy link
Contributor

@TimothyMothra Can we port this change as a hotfix to 2.8 ? (I'd assume the process will not be as smooth, as this code was originally in aspnetcore repo.) I'll ask in standup.

@illay1994
Copy link
Author

@TimothyMothra and @cijothomas
I was create already PR in aspnetcore repo. Branch (bug/httpcontext-aspcore30) started from tag 2.8.2
microsoft/ApplicationInsights-aspnetcore#1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants