-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RouteData not setted in ASP core 3.0 #1318
Conversation
…pNetCore.Mvc.BeforeAction" event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!.
More than the bug, this exposed lack of 3.0 test which would have caught this. We added 3.0 test, but it was doing minimal validation. Will need to migrate all 2.0 tests to 3.0. (separate from this PR ofcourse)
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
@illay1994 Can you please update |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
We're going to merge a larger PR first and then merge this one tonight or tomorrow morning. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@illay1994 We published 2.12-Beta4 this morning including your changes! :) |
@TimothyMothra Can we port this change as a hotfix to 2.8 ? (I'd assume the process will not be as smooth, as this code was originally in aspnetcore repo.) I'll ask in standup. |
@TimothyMothra and @cijothomas |
#1316 - Fixed problem with read HttpContext on "Microsoft.AspNetCore.Mvc.BeforeAction" event