You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, the dependencies of Mds (net46) would require creating an entirely new test project for this and I am not comfortable enough with this codebase to do that.
Sidenote, why is there SqlClientDiagnosticSourceListenerTests.cs and SqlClientDiagnosticSourceListenerTestsCopy.cs?
CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.
No, that would be a bit premature...
For significant contributions please make sure you have completed the following items:
Design discussion issue #
Changes in public surface reviewed
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.
I (as the author of the code in this PR) did not add any tests to actually validate that this fixes the issue. That would involve creating a new test project that is compatible with the requirements of MDS or upgrading the current project to Net Fwk 4.6.
While I could figure out what was wrong and add a fix that compiles, doing the test thing would be going deeper into the rabbit hole than I can do right now.
So I left the PR as a draft (so non-merge:able) here hoping that would at least help someone else fix the issue faster.
Sorry for the delay - Will review this and include this in 2.17 release, as 2.16 is a light release with only major change is just the version bump of DiagnosticSource nuget version.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…System.Data(.SqlClient).
Fix Issue #2032 .
Changes
Se title.
Checklist
No, the dependencies of Mds (net46) would require creating an entirely new test project for this and I am not comfortable enough with this codebase to do that.
Sidenote, why is there SqlClientDiagnosticSourceListenerTests.cs and SqlClientDiagnosticSourceListenerTestsCopy.cs?
No, that would be a bit premature...
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build