Removed null check as it can break the JsonWriter flow.

[hallatore]

We should't remove properties that are null as it might brake the flow of the JsonWriter.

PS: Why was this done in the first place? What could break on the back end with this change?

Ref #319

[msftclas]

Hi @hallatore, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[abaranch]

Thank you for your contribution. I will check whether we can fix it on the serializer side before accepting the contribution. I think the initial idea was to not send null values since that unnecessarily increases package size. (Also I'm pretty sure some unit tests would fail.)

[hallatore]

I get why the code is there, but feel it might be at the wrong place. Right now it looks like a hack since it's placed in the middle of it all.

And it's also not included on this almost identical method. https://github.com/microsoft/ApplicationInsights-dotnet/blob/develop/src/Core/Managed/Shared/Extensibility/Implementation/JsonWriter.cs#L108-L121

[abaranch]

Sorry, I got pulled away by a different task today.
Do you have a proposal how to fix it but still keep removing null values?..

[hallatore]

I would normally say that it makes little sense to trim out the null's if it isn't a big issue. So how does the compressed payload look without this code? How much are we adding?

Easiest way to patch this (if it's a problem) is probably at the .Count > 0 step at https://github.com/microsoft/ApplicationInsights-dotnet/blob/develop/src/Core/Managed/Shared/Extensibility/Implementation/JsonWriter.cs#L110

[abaranch]

I do not have numbers right away but since you are saying that fixing it with keeping existing behavior has the same complexity, let's keep the behavior.

[abaranch]

I created a pull request that includes both

• to keep existing functionality, change sanitization rules
• your fix in case if in the future we decide that we want to start sending nulls
  Thank you for finding the issue and help with resolving it,.