Made sampling based on UserId configurable #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the configuration out as far as the AdaptiveSamplingTelemetryProcessor - Added unit test to ensure sampling with/without user id is tested - Updated changelog for beta 2.5.0-beta2 - Updated PublicAPI.Unshipped.txt Linked to issue #625
d3r3kk
requested review from
SergeyKanzhelev,
Dmitry-Matveev and
TimothyMothra
SergeyKanzhelev
suggested changes
Nov 16, 2017
| /// services on operation_Id field. | ||
| /// </remarks> | ||
| /// </summary> | ||
| public bool AllowSamplingBasedOnUserId { get; set; } |
There was a problem hiding this comment.
Allow is not the best verb here. Maybe Calculate like in CalculateSamplingScoreFromUserId or Use like in UseUserIdSamplingScore
| /// Default is false. | ||
| /// | ||
| /// <remarks> | ||
| /// Calculation of the sampling score based on user_Id field is disabled by default to ensure successful correlation across many |
There was a problem hiding this comment.
nit: why are you switching to Kusto names of the fields in remark?
| @@ -13,12 +13,13 @@ internal static class SamplingScoreGenerator | |||
| /// Generates telemetry sampling score between 0 and 100. | |||
| /// </summary> | |||
| /// <param name="telemetry">Telemetry item to score.</param> | |||
| /// <param name="allowUserId">Sampling score can be determined by using the Context.User.Id information, default is false.</param> | |||
There was a problem hiding this comment.
Add remark that is can be used for backward compatibility
| @@ -27,8 +27,8 @@ public void SamplingScoreGeneratedUsingUserIdIfPresent() | |||
| requestTelemetry.Context.User.Id = userId; | |||
| requestTelemetry.Context.Operation.Id = GenerateRandomOperaitonId(); | |||
|
|
|||
| var eventTelemetrySamplingScore = SamplingScoreGenerator.GetSamplingScore(eventTelemetry); | |||
| var requestTelemetrySamplingScore = SamplingScoreGenerator.GetSamplingScore(requestTelemetry); | |||
| var eventTelemetrySamplingScore = SamplingScoreGenerator.GetSamplingScore(eventTelemetry, true); | |||
There was a problem hiding this comment.
update the name of the test method. IfPresentAndConfigured
| requestTelemetry.Context.Operation.Id = operationId; | ||
| requestTelemetry.Context.User.Id = userId; | ||
|
|
||
| var eventTelemetrySamplingScore = SamplingScoreGenerator.GetSamplingScore(eventTelemetry, true); |
There was a problem hiding this comment.
ever test it with false?
|
Shutting this PR down, we will simply remove our calculation of sampling score based on Context.User.Id altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue #625
For significant contributions please make sure you have completed the following items: