Remove sampling score on telemetry items related to Context.User.Id #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 16, 2017
CHANGELOG.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| This changelog will be used to generate documentation on [release notes page](http://azure.microsoft.com/en-us/documentation/articles/app-insights-release-notes-dotnet/). | |||
|
|
|||
| ## Version 2.5.0-beta2 | |||
|
|
|||
| - Remove calculation of sampling-score based on Context.User.Id | |||
There was a problem hiding this comment.
Can you add link to the issue as well? So that it's easier for someone reading change log to understand more about the change.
#625
cijothomas
approved these changes
Nov 16, 2017
|
@d3r3kk due to some issues with CI builds, can you trigger a manual build for this one. (Don't merge before doing that!) |
Dmitry-Matveev
approved these changes
Nov 17, 2017
|
Please also take a closer look at the functional tests executed in the build to make sure they are not affected by the change in the sampling (they should not be, however, it's worth to keep an eye on it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to keep the sample scoring with Context.User.Id. Remove the code and tests surrounding this calculation.
Issue #625