-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netstandard2.0 target for ServerTelemetryChannel and remove Newtonsoft.Json dependency (#800) #801
Add netstandard2.0 target for ServerTelemetryChannel and remove Newtonsoft.Json dependency (#800) #801
Conversation
Please add a test project targetting 2.0 mimicking this https://github.com/Microsoft/ApplicationInsights-dotnet/tree/develop/Test/ServerTelemetryChannel.Test/NetCore.Tests |
622d0a3
to
9441010
Compare
@cijothomas I've added the 2.0 tests |
ab61b54
to
51feb6f
Compare
@clguimanMSFT Can you please update the changelog? |
@MS-TimothyMothra should I add the changes under 2.7.0-beta1? |
@clguimanMSFT you can call it 2.6.2. |
Common.props
Outdated
@@ -21,7 +21,7 @@ | |||
<CodeAnalysisRuleSet>$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), 'ApplicationInsightsSDKRules.ruleset'))\ApplicationInsightsSDKRules.ruleset</CodeAnalysisRuleSet> | |||
</PropertyGroup> | |||
|
|||
<PropertyGroup Condition="'$(Configuration)' == 'Release'"> | |||
<PropertyGroup Condition="'$(Configuration)' == 'Release' and '$(TargetFramework)'!='netstandard2.0'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#803 - so that we know this is disabled for 2.0 target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition should be on the "RunCodeAnalysis" property. The other properties (particularly Optimize and DefineConstants) should still be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
@SergeyKanzhelev / @Dmitry-Matveev - Please have a look at this. We have modified build defs to test this (and manually ran them - all good) |
9cf4d02
to
606845f
Compare
<DefineConstants>$(DefineConstants);NETCOREAPP</DefineConstants> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add conflicting Newtonsoft for the test app to make sure our dependency does not get back with the future commits? (and if it does, the test will fail?)
Add netstandard2.0 target for ServerTelemetryChannel and remove Newtonsoft.Json dependency (#800)
Fix Issue #800 .
Replaced JavaScriptSerializer with DataContractjsonSerializer (exists in netstandard 2.0 & net45)
I had to update the BackendResponse member attributes with IsRequired=true so BackoffLogicManagerTest.IfContentIsUnexpectedJsonNullIsReturned won't fail.
For significant contributions please make sure you have completed the following items: