Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more broken namespaces #810

Merged
merged 2 commits into from
May 21, 2018

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented May 21, 2018

AdaptiveSamplingPercentageEvaluatedCallback is another public object that changed namespaces

Fix Issue #727 .
Continuation of the same issue. found one more public object that was changed.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
  • The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.

@xt0rted
Copy link

xt0rted commented May 21, 2018

Are CI builds published to a myget feed at all? The one at https://www.myget.org/F/applicationinsights/api/v3/index.json doesn't seem to have any for the 2.6.x versions and it'd make verifying these changes easier.

@TimothyMothra
Copy link
Member Author

TimothyMothra commented May 21, 2018

@xt0rted I intend to publish THIS to MyGet today.

We don't auto-publish anything to MyGet as of today. Even though that's a private feed MyGet is external to our company so those packages have to be signed by Microsoft for release, and that process has specific requirements.

@TimothyMothra TimothyMothra merged commit 29551bd into develop May 21, 2018
TimothyMothra added a commit that referenced this pull request May 21, 2018
* AdaptiveSamplingPercentageEvaluatedCallback is another public object that changed namespaces
@TimothyMothra TimothyMothra deleted the tilee/727_fix_more_broken_namespaces branch June 13, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants