Reuse httpclient to avoid leaking in .net core 2.1 #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #594 .
On .Net Core 2.1, creating new httpclient for every request has led to leaking of httpConnection related objects/timer eventually leading to high CPU. More details in below issue
microsoft/ApplicationInsights-aspnetcore#690
Didn't find an easy way to unit test this, so relying on existing tests of channel.
For significant contributions please make sure you have completed the following items: