Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse httpclient to avoid leaking in .net core 2.1 #857

Merged
merged 4 commits into from
Jul 6, 2018

Conversation

cijothomas
Copy link
Contributor

@cijothomas cijothomas commented Jul 6, 2018

Fix Issue #594 .
On .Net Core 2.1, creating new httpclient for every request has led to leaking of httpConnection related objects/timer eventually leading to high CPU. More details in below issue
microsoft/ApplicationInsights-aspnetcore#690

Didn't find an easy way to unit test this, so relying on existing tests of channel.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
  • The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.

….1 of .net core runtime, not reusing httpclient leads to leaks of httpConnections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants