Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify all existing Telemetry types to implement IExtension #890

Merged
merged 31 commits into from
Aug 9, 2018
Merged

Modify all existing Telemetry types to implement IExtension #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8f8f57c
Modify DependencyTelemetry to implement IExtension
cijothomas Jul 31, 2018
ae9ec08
Trials
cijothomas Aug 2, 2018
522754e
more
cijothomas Aug 3, 2018
3057f67
al telemetry now does time and name as per old formats
cijothomas Aug 3, 2018
f6ab449
Check for null severity level. Added StartObject for every Type
cijothomas Aug 3, 2018
f0d70a2
removed temp things.
cijothomas Aug 3, 2018
805468b
exception handle severity level correctly
cijothomas Aug 6, 2018
4bed401
Individual Telemetry implementations need not call start stop but ser…
cijothomas Aug 6, 2018
08ed95a
Serialization to completely dependend on Serialize method of IExtension
cijothomas Aug 6, 2018
c513199
Supportwriting complex combject in ISerializationWriter
cijothomas Aug 6, 2018
e1bf746
Make base data implement IExtension and use WriteComplex Property API…
cijothomas Aug 6, 2018
a38871d
Removed dead code. entire serialization occurs by ISerializationWrite…
cijothomas Aug 7, 2018
66c981d
Dependency - duration serializes to default value when not set
cijothomas Aug 7, 2018
b917369
minor
cijothomas Aug 7, 2018
719fbbf
Unit test the JsonSerializationWriter by serializing a complex object
cijothomas Aug 7, 2018
d3ad81b
Serialize duration correctly
cijothomas Aug 7, 2018
17f8ee0
Reuse code to write envelop properties
cijothomas Aug 7, 2018
f9000fc
Renamings and testing jsonserializationwriter
cijothomas Aug 7, 2018
da90aec
Merge branch 'develop' into cithomas/extensibiltychanges
cijothomas Aug 7, 2018
5b7fb36
Modified interfaces to be more correct.
cijothomas Aug 8, 2018
2fec31e
ITelemetry contains a Serialize method. Though same signature as ISer…
cijothomas Aug 8, 2018
1f19af8
Copying TC.GlobalProperties to Item.Properties is done outside serial…
cijothomas Aug 8, 2018
360931b
Fix typos comments
cijothomas Aug 8, 2018
f2a412a
ITelemetry has serialize so JsonSerializer dont need to cast to anyth…
cijothomas Aug 8, 2018
9a8bd60
Removed ICloneable as clone can be defined in IExtension itelf.
cijothomas Aug 8, 2018
c84fdc1
All types to serialzie their Extension
cijothomas Aug 9, 2018
f2b6936
Re-enable public api analyzer
cijothomas Aug 9, 2018
74b83e1
Public API files added
cijothomas Aug 9, 2018
95f3307
remove bad comment
cijothomas Aug 9, 2018
35197ed
Test fix
cijothomas Aug 9, 2018
f7f98d7
Test fix
cijothomas Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Microsoft.ApplicationInsights.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.26430.16
VisualStudioVersion = 15.0.27130.2036
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.ApplicationInsights.Tests", "Microsoft.ApplicationInsights.Tests", "{C2FEEDE5-8CAE-41A4-8932-42D284A86EA7}"
EndProject
Expand Down
35 changes: 27 additions & 8 deletions PublicAPI/Microsoft.ApplicationInsights.dll/net45/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,40 +296,59 @@ Microsoft.ApplicationInsights.DataContracts.TelemetryContext.Flags.set -> void
const Microsoft.ApplicationInsights.DataContracts.TelemetryContext.FlagDropIdentifiers = 2097152 -> long
Microsoft.ApplicationInsights.Channel.ITelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Channel.ITelemetry.Extension.set -> void
Microsoft.ApplicationInsights.Channel.ITelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Extension.set -> void
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Extension.set -> void
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Extension.set -> void
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter
Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Extensibility.IExtension.DeepClone() -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Extensibility.IExtension.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteDictionary(string name, System.Collections.Generic.IDictionary<string, string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteEndObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteList(string name, System.Collections.Generic.IList<string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.TimeSpan? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, bool? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, string value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, double? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, int? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, string value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, bool? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.TimeSpan? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.DateTimeOffset? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IList<string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IList<Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IDictionary<string, string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IDictionary<string, double> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject() -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteEndObject() -> void
35 changes: 27 additions & 8 deletions PublicAPI/Microsoft.ApplicationInsights.dll/net46/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,40 +296,59 @@ Microsoft.ApplicationInsights.DataContracts.TelemetryContext.Flags.set -> void
const Microsoft.ApplicationInsights.DataContracts.TelemetryContext.FlagDropIdentifiers = 2097152 -> long
Microsoft.ApplicationInsights.Channel.ITelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Channel.ITelemetry.Extension.set -> void
Microsoft.ApplicationInsights.Channel.ITelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.AvailabilityTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.EventTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.ExceptionTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.MetricTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PageViewPerformanceTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PageViewTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.PerformanceCounterTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.SessionStateTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Extension.set -> void
Microsoft.ApplicationInsights.DataContracts.TraceTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Extension.set -> void
override Microsoft.ApplicationInsights.DataContracts.DependencyTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Extension.set -> void
override Microsoft.ApplicationInsights.DataContracts.RequestTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Extension.get -> Microsoft.ApplicationInsights.Extensibility.IExtension
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Extension.set -> void
abstract Microsoft.ApplicationInsights.Extensibility.Implementation.OperationTelemetry.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter
Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Extensibility.IExtension.DeepClone() -> Microsoft.ApplicationInsights.Extensibility.IExtension
Microsoft.ApplicationInsights.Extensibility.IExtension.Serialize(Microsoft.ApplicationInsights.Extensibility.ISerializationWriter serializationWriter) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteDictionary(string name, System.Collections.Generic.IDictionary<string, string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteEndObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteList(string name, System.Collections.Generic.IList<string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.TimeSpan? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, bool? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, string value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, double? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, int? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, string value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, bool? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.TimeSpan? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.DateTimeOffset? value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter value) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IList<string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IList<Microsoft.ApplicationInsights.Extensibility.ISerializableWithWriter> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IDictionary<string, string> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteProperty(string name, System.Collections.Generic.IDictionary<string, double> items) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject(string name) -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteStartObject() -> void
Microsoft.ApplicationInsights.Extensibility.ISerializationWriter.WriteEndObject() -> void
Loading