ITelemetry.SerializeData instead of Serialize #892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ITelemetry implement SerializeData instead of Serialize, as only Data part need to be serialized. Rest of the content are known within ITelemetry itself and hence require no explicit serialization call.
So if user want to define a new type, implement ITelemetry. (which include SerializeData - to let channels know what fields are defined by the user. All channels should know how to serialzie the rest of the content as they are on
ITelemetry
itself.)For significant contributions please make sure you have completed the following items: