[2.x] Fix Crashing with Old Node.JS Versions When Manually Instrumenting #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonWeber
changed the title
hectorhdzg
reviewed
Jul 15, 2024
README.md
Outdated
| @@ -32,7 +32,8 @@ You can manually track more aspects of your app and system using the API describ | |||
|
|
|||
|
|
|||
|
|
|||
| ## Supported Node.JS versions | |||
| ## Supported Node.JS versions | |||
| > *Note:* Versions of Node.JS that are not supported by the [JS Azure SDK](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) will not support AAD authentication. | |||
There was a problem hiding this comment.
This is a little bit confusing, we need azure/identity package to be included to use the feature, as customer need to pass an instance of a Credential object, so this extra note could cause more confusion than helping here.
There was a problem hiding this comment.
I'll reword to make it clearer what the exception to our support for older versions really is.
There was a problem hiding this comment.
I moved the note to the aadCredential description. Hopefully that makes it clearer that old versions of Node don't impact using any other scenario with the SDK.
hectorhdzg
reviewed
Jul 15, 2024
hectorhdzg
reviewed
Jul 15, 2024
JacksonWeber
changed the title
JacksonWeber
changed the title
JacksonWeber
changed the title
hectorhdzg
approved these changes
Jul 16, 2024
JacksonWeber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix node.js versions that are not supported by the Azure SDK by conditionally loading Azure SDK packages when manually instrumenting.
Azure/azure-sdk-for-js#30217