Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error log if AZDCAP_DEBUG_LOG_LEVEL env var is not set #138

Open
eddyashton opened this issue Apr 16, 2021 · 1 comment
Open

Error log if AZDCAP_DEBUG_LOG_LEVEL env var is not set #138

eddyashton opened this issue Apr 16, 2021 · 1 comment

Comments

@eddyashton
Copy link
Member

I believe #114 was closed prematurely. There are 2 related PRs which do not fix the underlying issue:

However the original issue is still present - if AZDCAP_DEBUG_LOG_LEVEL is not set, the following log will be output:

Azure Quote Provider: libdcap_quoteprov.so [ERROR]: Could not retrieve environment variable for 'AZDCAP_DEBUG_LOG_LEVEL'

As far as I can tell, this comes from init_debug_log, which is reporting its errors directly with printf. I believe this error message should be dropped, to match the behaviour of dropping other similar logging messages when this env var is undefined.

@Shivr-ctrl
Copy link
Collaborator

Ack, Will fix it in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants