Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error log if AZDCAP_DEBUG_LOG_LEVEL env var is not set #114

Closed
jumaffre opened this issue Jul 15, 2020 · 2 comments
Closed

Error log if AZDCAP_DEBUG_LOG_LEVEL env var is not set #114

jumaffre opened this issue Jul 15, 2020 · 2 comments

Comments

@jumaffre
Copy link
Contributor

If the AZDCAP_DEBUG_LOG_LEVEL environment is not set, the following error log is printed:
Azure Quote Provider: libdcap_quoteprov.so [ERROR]: Could not retreive environment variable for 'AZDCAP_DEBUG_LOG_LEVEL'

I believe this is undesirable behaviour and the library should set a sensible default value for the log level that could be overridden with AZDCAP_DEBUG_LOG_LEVEL.
@achamayou
Copy link
Member

That should be a warning/info, it's definitely not an error. Filed #115 for the typo.

@deschuma
Copy link
Collaborator

Thanks agreed - we'll get this fixed

This was referenced Jul 17, 2020
Closed
Merged
deschuma added a commit that referenced this issue Aug 6, 2020
@deschuma
Use Cache-Control header to determine how long collateral should be c…
3730b9f 
…ached for (#122)

Allow PCK Cache to determine how long to cache collateral. Ordinarily, collateral should always be cached for 24 hours but PCK cache will examine the expiration time of the collateral and notify the Azure DCAP Client how long the collateral should be cached for.

For example, if the collateral will expire in 3 hours, the cache-control header will tell Azure DCAP Client to cache the collateral for only three hours so Azure DCAP client will re-query for newer collateral in that time frame.

This PR also addresses issue #114 by re-classifying errors reading environment variables to be warning instead of errors. The library is configured to operate with sensible defaults if no environment variables are defined.
@jumaffre jumaffre mentioned this issue Oct 29, 2020
Open
@eddyashton eddyashton mentioned this issue Apr 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achamayou @jumaffre @deschuma