Use Cache-Control header to determine cache expiry time #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deschuma
force-pushed
the
dev_deschuma_cache_from_headers
branch
from
02917ef
to
951686b
Compare
deschuma
force-pushed
the
dev_deschuma_cache_from_headers
branch
from
951686b
to
856b7f7
Compare
…ry operates with resasonable defaults if any are missing
deschuma
force-pushed
the
dev_deschuma_cache_from_headers
branch
from
856b7f7
to
1410d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows PCK Cache to determine how long to cache collateral. Ordinarily, collateral should always be cached for 24 hours but PCK cache will now examine the expiration time of the collateral and notify the Azure DCAP Client how long the collateral should be cached for.
For example, if the collateral will expire in 3 hours, the cache-control header will tell Azure DCAP Client to cache the collateral for only three hours so Azure DCAP client will re-query for newer collateral in that time frame
This PR also addresses issue #114 by re-classifying errors reading environment variables to be warning instead of errors. The library is configured to operate with sensible defaults if no environment variables are defined.