-
Notifications
You must be signed in to change notification settings - Fork 616
Added k4a_image_get/set_system_timestamp_nsec #350
Conversation
…mestamp_nsec. libuvc is now a forked repo with patches applied to Azure-Kinect branch. Updated libuvc so it can report capture_time
This may be out of scope for this change, but figured I'd mention it: Refers to: include/k4a/k4a.h:255 in ac64c8d. [](commit_id = ac64c8d, deletion_comment = False) |
Co-Authored-By: Matt Schulte <schultetwin1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have 1 comment about a change to the MIN macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to contributiuon policies, changing this to request changes since I would like MIN changed.
|
Ugh, its a GNU extension. Good find. If we are never using these MIN and MAX macros in C code, then should we include them? C++ provides a much safer std::max and std::min that we can use. |
Talked with Wes offline, we are using these macros in C code. Looks good to me! |
Fixes #198
Description of the changes:
Before submitting a Pull Request:
I tested changes on: