support multiple lines in devcontainer action #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
yuvalyaron
approved these changes
Dec 12, 2024
|
Not sure this should have been merged, the changes are typically made upstream to common files and then pulled down to this repo. Not sure it breaks anything though, @tamirkamara ? |
|
It got merged automatically, anyway I need that for the next PR, cause I'm counting on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple lines in devcontainer action
Before this PR CI workflow developers could only code commands in a single line (inline) to run inside devcontainer,
this becomes challenging to code complex scenarios and maintain it overtime as it is less readable.
This PR introduces a way to embed multiple shell command lines which are more readable and maintainable,
this inline script then materializes into a temp unique shell file which is mounted as
command.shfile inside the workspace path.