Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow for registering TRE bundle into a TRE environment #117

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

guybartal
Copy link
Collaborator

Add workflow for building, publishing and registering TRE bundle into a TRE environment

What is being addressed

This PR adds a workflow that will build, publish and register a TRE bundle into a TRE environment.

How is this addressed

  • it runs the correct make register command inside devcontainer action according to the provided workflow parameters.
  • by default, if not provided, it will build, publish and register the base workspace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (3)

.github/workflows/register_tre_bundle.yml:230

  • The syntax for setting default values is incorrect. It should be ${{ inputs.bundle_name }} without the default value.
bundle_name="${{ inputs.bundle_name || 'base' }}"

.github/workflows/register_tre_bundle.yml:234

  • Variables should be quoted to prevent issues with special characters. Use echo "bundle_name: [\"${bundle_name}\"]".
echo "bundle_name: [${bundle_name}]"

.github/workflows/register_tre_bundle.yml:255

  • Variables should be quoted in shell commands to prevent issues with spaces. Use make user_resource_bundle BUNDLE="${bundle_name}" WORKSPACE_SERVICE="${workspace_service_name}".
make user_resource_bundle BUNDLE="${bundle_name}" WORKSPACE_SERVICE="${workspace_service_name}"
@guybartal guybartal enabled auto-merge (squash) December 15, 2024 12:32
@guybartal guybartal requested review from yuvalyaron and removed request for marrobi and tamirkamara December 17, 2024 09:28
@guybartal guybartal merged commit e552aa4 into main Dec 17, 2024
2 checks passed
@yuvalyaron yuvalyaron deleted the guybartal/register-tre-bundle branch December 17, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants