-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused vars from workflows #74
base: main
Are you sure you want to change the base?
Remove unused vars from workflows #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @marrobi I think that we should also create a PR in the main repo to remove the legacy use of it. In e2e_tests/helpers.py lines 117-120. WDYT? If you'd like I can do that.
@tamirkamara so what are you suggesting? Should these variables made optional in the |
|
Resolves #61
I hit the same issue, so thought I'd propose a solution (tested and works ok)
What is being addressed
Workflows include inputs that are unused. The checks and references to
TEST_APP_ID
,TEST_WORKSPACE_APP_ID
,TEST_WORKSPACE_APP_SECRET
andMS_TEAMS_WEBHOOK_URI
are removed. Also uses the value of$ec
rather than the literal string, which I think is a 🐞