Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock processor handles request cancellation #1968

Closed
5 tasks
Tracked by #1740
eladiw opened this issue Jun 2, 2022 · 3 comments · Fixed by #2584
Closed
5 tasks
Tracked by #1740

Airlock processor handles request cancellation #1968

eladiw opened this issue Jun 2, 2022 · 3 comments · Fixed by #2584
Assignees
Labels
airlock story Stories are the smallest unit of work to be done for a project.

Comments

@eladiw
Copy link
Contributor

eladiw commented Jun 2, 2022

Description

As an Airlock processor in TRE
I want to be able to be able to consume and operate on cancel event
So that requests cancelation are handled

Acceptance criteria

@eladiw eladiw added the story Stories are the smallest unit of work to be done for a project. label Jun 2, 2022
@eladiw eladiw changed the title Airlock processor handles request cancelation Airlock processor handles request cancelation Jun 2, 2022
@tamirkamara tamirkamara changed the title Airlock processor handles request cancelation Airlock processor handles request cancellation Jun 2, 2022
@joalmeid joalmeid mentioned this issue Jun 2, 2022
36 tasks
@joalmeid joalmeid added this to the Release 0.4 milestone Jun 2, 2022
@eladiw
Copy link
Contributor Author

eladiw commented Jul 6, 2022

@joalmeid @marrobi @yuvalyaron
The story talks about moving the data to a NEW storage accound called cancelled.
I think its an overkill, how about we simply delete the data of a cancelled request.

Reminder, we allow to cancel only in-review requests or draft requests, so its not possible to cancel a rejected or approved requests for example...

@marrobi
Copy link
Member

marrobi commented Jul 6, 2022

I think so... we don't really want the data hanging around.

@eladiw
Copy link
Contributor Author

eladiw commented Jul 16, 2022

@tamirkamara @yuvalyaron so let's delete the data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airlock story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants