Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Azure Function ToDeleteTrigger to DataDeletionTrigger #2592

Merged
merged 27 commits into from
Sep 14, 2022
Merged

Rename Azure Function ToDeleteTrigger to DataDeletionTrigger #2592

merged 27 commits into from
Sep 14, 2022

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Sep 13, 2022 •
edited
Loading

Part of #1968

What is being addressed

As discussed in PR #2584, ToDeleteTrigger is renamed to DataDeletionTrigger

How is this addressed

  • Renamed files and references

yuvalyaron and others added 21 commits September 11, 2022 17:32
@yuvalyaron
add 'previous status' field to 'status changed' message
1b011ef
@yuvalyaron
add support for container deletion in azure function 'toDeleteTrigger'
a64bd87
@yuvalyaron
handle request cancellation in StatusChangedQueueTrigger
c23976b
@yuvalyaron
Merge branch 'main' of https://github.com/microsoft/AzureTRE into fea…
c4bdaca 
…ture/1968-airlock-handle-request-cancellation
@yuvalyaron
fix output event names
fb0266b
@yuvalyaron
update versions
e9c884e
@yuvalyaron
clean code by extracting to methods
bfff96e
@yuvalyaron
Merge branch 'main' of https://github.com/microsoft/AzureTRE into fea…
894e628 
…ture/1968-airlock-handle-request-cancellation
@yuvalyaron
update changelog
15bfa87
@yuvalyaron
fix unit tests
fdbe3b4
@yuvalyaron
add unit tests
881dd42
@yuvalyaron
Merge branch 'main' of https://github.com/microsoft/AzureTRE into fea…
89444dd 
…ture/1968-airlock-handle-request-cancellation
@yuvalyaron
use already declared variables instead of request_properties
b527e13
@yuvalyaron
update api version
5e55108
@yuvalyaron @eladiw
update changelog
0a1daa9 
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
@yuvalyaron @eladiw
update log message
ceebec4 
Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com>
@yuvalyaron
Merge branch 'main' of https://github.com/microsoft/AzureTRE into fea…
bcc0e0a 
…ture/1968-airlock-handle-request-cancellation
@yuvalyaron
rename references of toDelete event to dataDeletion event in statusCh…
24f6936 
…anged function
@yuvalyaron
change toDelete to DataDeletion
4528e60
@yuvalyaron
update version and changelog
a44e3bd
@yuvalyaron
rename ToDelete to DataDeletion
de67d25
@yuvalyaron yuvalyaron mentioned this pull request Sep 13, 2022
Merged
@github-actions
Copy link

github-actions bot commented Sep 13, 2022 •
edited
Loading

Unit Test Results

21 tests  +4   21 ✔️ +4   0s ⏱️ -11s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit ae62639. ± Comparison against base commit e6b62f4.

This pull request removes 17 and adds 21 tests. Note that renamed tests count towards both. 
test_provisioned_health_api ‑ test_health
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-gitea]
test_ui ‑ test_ui
test_workspace_service_templates ‑ test_create_workspace_service_templates
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-azureml]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-guacamole]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-innereye]
…

tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_copy_data_adds_copied_from_metadata
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_copy_data_fails_if_no_blobs_to_copy
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_copy_data_fails_if_too_many_blobs_to_copy
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_get_blob_info_from_topic_and_subject
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_get_blob_info_from_url
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_get_blob_url_should_return_blob_url
tests.shared_code.test_blob_operations.TestBlobOperations ‑ test_get_blob_url_without_blob_name_should_return_container_url
tests.test_data_deletion_trigger.TestDataDeletionTrigger ‑ test_delete_blob_and_container_if_last_blob_deletes_container
tests.test_data_deletion_trigger.TestDataDeletionTrigger ‑ test_delete_blob_and_container_if_last_blob_deletes_container_if_no_blob_specified
tests.test_data_deletion_trigger.TestDataDeletionTrigger ‑ test_delete_blob_and_container_if_last_blob_doesnt_delete_container
…

♻️ This comment has been updated with latest results.

@yuvalyaron
Merge branch 'main' of https://github.com/microsoft/AzureTRE into 196…
7850ddd 
…8-rename-to-delete-trigger

� Conflicts:
�	airlock_processor/StatusChangedQueueTrigger/function.json
�	airlock_processor/tests/test_data_deletion_trigger.py
@yuvalyaron
update version
0d19ae7
@yuvalyaron
fix terraform file format
5980aae
@yuvalyaron
fix terraform variable values
4f9dc4b
@yuvalyaron
update core version
8de2ae6
eladiw
eladiw approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@eladiw eladiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuvalyaron yuvalyaron marked this pull request as ready for review September 14, 2022 09:43
@yuvalyaron
Copy link
Collaborator Author

/test

@yuvalyaron yuvalyaron enabled auto-merge (squash) September 14, 2022 09:44
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3051774474 (with refid de353fa1)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 03a3aab into microsoft:main Sep 14, 2022
@yuvalyaron yuvalyaron deleted the 1968-rename-to-delete-trigger branch September 14, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladiw eladiw eladiw approved these changes

Assignees
No one assigned
Labels
airlock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvalyaron @eladiw