Block TRE access to Terraform/Hashicorp domains (#2590)

* firewall blocks terraform

* update min fw version

* update changelog

CHANGELOG.md

@@ -5,7 +5,7 @@
 
 **BREAKING CHANGES & MIGRATIONS**:
 
-*
+* Firewall now blocks terraform/hasicorp domains ([#2590](https://github.com/microsoft/AzureTRE/pull/2590)). **Migration** is manual - update the templateVersion of `tre-shared-service-firewall` resource in Cosmos to `0.5.0`. Check the PR for more details.
 
 FEATURES:
 

templates/shared_services/firewall/porter.yaml

@@ -1,6 +1,6 @@
 ---
 name: tre-shared-service-firewall
-version: 0.4.3
+version: 0.5.0
 description: "An Azure TRE Firewall shared service"
 dockerfile: Dockerfile.tmpl
 registry: azuretre

templates/shared_services/firewall/terraform/firewall.tf

@@ -156,26 +156,6 @@ resource "azurerm_firewall_application_rule_collection" "resource_processor_subn
     source_addresses = data.azurerm_subnet.resource_processor.address_prefixes
   }
 
-  # TODO: remove this rule when all bundles have mirrored their plugins
-  # https://github.com/microsoft/AzureTRE/issues/2445
-  rule {
-    name = "terraform-sources"
-    protocol {
-      port = "443"
-      type = "Https"
-    }
-    protocol {
-      port = "80"
-      type = "Http"
-    }
-
-    target_fqdns = [
-      "registry.terraform.io",
-      "releases.hashicorp.com",
-    ]
-    source_addresses = data.azurerm_subnet.resource_processor.address_prefixes
-  }
-
   depends_on = [
     azurerm_firewall_application_rule_collection.shared_subnet
   ]