Block TRE access to Terraform/Hashicorp domains #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3042442645 (with refid (in response to this comment from @tamirkamara) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3043310345 (with refid (in response to this comment from @tamirkamara) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3047555810 (with refid (in response to this comment from @tamirkamara) |
tanya-borisova
added a commit
to tanya-borisova/AzureTRE
that referenced
this pull request
Oct 10, 2022
…)" to be added back in a future release This reverts commit e6b62f4.
tanya-borisova
added a commit
that referenced
this pull request
Oct 10, 2022
Revert "Block TRE access to Terraform/Hashicorp domains (#2590)" to be added back in a future release
marrobi
pushed a commit
that referenced
this pull request
Oct 11, 2022
Revert "Block TRE access to Terraform/Hashicorp domains (#2590)" to be added back in a future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2445
What is being addressed
With all bundles implementing Terraform provider mirroring it's time to start blocking TRE communication to Terraform/Hasihcorp domains.
Migration
It's advised to upgrade your firewall to the new
0.5.0version if all your deployed tre resources are at (or above) the versions below.If you have created and deployed custom templates that use Terraform, you need to make sure you mirror providers. Look at the dockerfile.tmpl of one our templates for an example.
The method to do this upgrade is manual - upgrade the templateVersion of
tre-shared-service-firewallresource in Cosmos to0.5.0