-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD settings on workspace creation page should adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION #2628
Comments
@marrobi should this still be open? |
auto_create
and do not prompt the user.auto_create
and do not prompt the user
auto_create
and do not prompt the user
I've updated the title and description to match the original intention now we have new ENV vars, and actually think its a bug, cost a few hours today. |
We discussed amending the error message (which isn't currently visible as per #2363 could be a way to mitigate). |
Another instance of this #3494 |
Another instance here - #3608 (reply in thread) |
When deploying a workspace the user is prompted to choose authentication settings. As these are defined by
AUTO_WORKSPACE_APP_REGISTRATION
andAUTO_WORKSPACE_GROUP_CREATION
they should not be user configurable as this can lead to mismatch with the app registration configuration and workspace deployment fails as per #3190Notes:
At present this need this file
https://github.com/microsoft/AzureTRE/blob/main/api_app/schemas/azuread.json
to be edited. This means that the API app needs to be rebuilt. I suggest the values in this file are dynamically generated so they can be customised without rebuilding the API image.The text was updated successfully, but these errors were encountered: