Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall migration crashes if no firewall deployed #2791

Closed
tanya-borisova opened this issue Oct 27, 2022 · 0 comments · Fixed by #2792
Closed

Firewall migration crashes if no firewall deployed #2791

tanya-borisova opened this issue Oct 27, 2022 · 0 comments · Fixed by #2792
Assignees
@tanya-borisova
Labels
bug Something isn't working

Comments

@tanya-borisova
Copy link
Contributor

Description

Firewall migration method crashes if there is no firewall deployed.
Although we do expect firewall to be deployed during a successful deployment, it would still be good to error out with a more helpful error message.
@tanya-borisova tanya-borisova added the bug Something isn't working label Oct 27, 2022
@tanya-borisova tanya-borisova self-assigned this Oct 27, 2022
@tanya-borisova tanya-borisova moved this to In Progress in AzureTRE - Crew Rock Oct 27, 2022
@tanya-borisova tanya-borisova linked a pull request Oct 27, 2022 that will close this issue
Fail Firewall migration if there's no firewall #2792
Merged
@tanya-borisova tanya-borisova mentioned this issue Oct 27, 2022
Merged
Repository owner moved this from In Progress to Done in AzureTRE - Crew Rock Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanya-borisova tanya-borisova

Labels
bug Something isn't working
Projects
No open projects
AzureTRE - Crew Rock
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail Firewall migration if there's no firewall microsoft/AzureTRE
1 participant
@tanya-borisova