Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Firewall migration if there's no firewall #2792

Conversation

tanya-borisova
Copy link
Contributor

Resolves #2791

What is being addressed

Explicitly fail Firewall migration if there is no firewall deployed.

@tanya-borisova tanya-borisova linked an issue Oct 27, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Unit Test Results

517 tests   517 ✔️  18s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 5e98138.

♻️ This comment has been updated with latest results.

@tanya-borisova
Copy link
Contributor Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3337580424 (with refid adc1d249)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova enabled auto-merge (squash) October 27, 2022 12:57
@tanya-borisova
Copy link
Contributor Author

/test-destroy-env

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre0971c40c)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3362380106)

@github-actions
Copy link

Destroying PR test environment (RG: rg-treadc1d249)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3362380106)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre0971c40c)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-treadc1d249)

@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3362655514 (with refid adc1d249)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:51 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:55 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 15:59 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:34 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:36 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:38 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 16:38 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 17:00 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 17:00 Inactive
@tanya-borisova tanya-borisova temporarily deployed to CICD October 31, 2022 17:02 Inactive
@tanya-borisova tanya-borisova merged commit 403804a into main Oct 31, 2022
@tanya-borisova tanya-borisova deleted the tborisova/2791-firewall-migration-crashes-if-no-firewall-deployed branch October 31, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall migration crashes if no firewall deployed
2 participants