Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI install dependency issue #3601

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3579

What is being addressed

The CLI will fail to install on the deployment repo due to a conflicting version with the cryptography dependency.

How is this addressed

  • We used an old method to install the python CLI component (aka easy_install) which caused the dependency version resolution failure. Moving to install via pip fixes the issue as now the right cryptography version is being discovered and installed.
    I've verified this works in the deployment repo too.

CHANGELOG.md Outdated Show resolved Hide resolved
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5451714977 (with refid 17827003)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b987e49.

@tamirkamara tamirkamara requested a review from marrobi July 4, 2023 06:59
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

As discussed seems odd that the dependencies are still defined in setup.py are they still required?

@tamirkamara tamirkamara merged commit 3278dae into main Jul 4, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3579-fix-cli-dependency branch July 4, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on opening repo in a codespace or locally in devcontainer
2 participants