-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airlock processor handles request Submission #1978
Conversation
c4c37e3
to
53fece3
Compare
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2466146573 (with refid (in response to this comment from @eladiw) |
29c9170
to
7848c35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing lots of airlock context, but done my best to review.
My main concern would be using any blob triggers to determine stage transitions - as this will pretty much pin us to one file and require a lot of refactoring if we wanted to support multiple in future.
7361316
to
d4175cf
Compare
63d67d4
to
53b8e3a
Compare
@damoodamoo @tamirkamara fixed all comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of small comments. Up to you...
terraform support for the az function
Added support for blob created event handling in the airlock processor airlock processor uses managed identity to get keys (+ added role assignment to SAs)
5388f03
to
135f3b8
Compare
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2492978719 (with refid (in response to this comment from @eladiw) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2493332545 (with refid (in response to this comment from @eladiw) |
/destroy-test-env |
🤖 pr-bot 🤖
You can use the following commands: (in response to this comment from @eladiw) |
/test-destroy-env |
Destroying PR test environment (RG: rg-tre3de19bb9)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2493701571) |
PR test environment destroy complete (RG: rg-tre3de19bb9) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2493857357 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2494018111 (with refid (in response to this comment from @eladiw) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2494112493 (with refid (in response to this comment from @eladiw) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2494217775 (with refid (in response to this comment from @eladiw) |
Fixes #1836
What is being addressed
Adding support for the StatusChangedEvent in the Airlock processor (for submission - import and export)
Consolidated the blob created queues into a single SB topic
Wired all TF scripts
Added support for the blobCreatedEvent in the AL processor
How is this addressed
How to test:
{ "data": {
"request_id" : "123",
"type":"import",
"status":"submitted" ,
"workspace_id":"124"
}
}
Check the in progress storage account , it should contain a new container with the same file.
Check the step result queue, you should find a step result event which states the request is now in-progress (transitioned from submitted)