Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Azure Monitor in core #2375

Merged
merged 12 commits into from
Aug 4, 2022
Merged

Conversation

tamirkamara
Copy link
Collaborator

Resolves #1321

What is being addressed

Azure monitor (app insights & log analytics) allowed ingestion data over the internet.
Plus, a lot of it was provisioned with ARM and not natively by Terraform

How is this addressed

  • Provision most resources by Terraform, only one left in ARM is the storage account link for app-insights profiles (not sure why we even need it)

@tamirkamara tamirkamara requested a review from stuartleeks July 31, 2022 07:37
Base automatically changed from tamirkamara/2124-destroy-stale-envs to main July 31, 2022 11:01
@github-actions
Copy link

github-actions bot commented Jul 31, 2022

Unit Test Results

0 tests   - 2   0 ✔️  - 1   0s ⏱️ - 1h 15m 6s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 1 

Results for commit 799a35a. ± Comparison against base commit ae8c251.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review August 1, 2022 05:22
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2772570125 (with refid d8c16678)

(in response to this comment from @tamirkamara)

Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2796676313 (with refid d8c16678)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2797798798 (with refid d8c16678)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit efb9414 into main Aug 4, 2022
@tamirkamara tamirkamara deleted the tamirkamara/refactor-azure-monitor branch August 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Monitor / App Insights allow ingestion over internet
2 participants