Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route table to airlock processor subnet #2414

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Add route table to airlock processor subnet #2414

merged 6 commits into from
Aug 8, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Aug 7, 2022 •
edited
Loading

Resolves #2097 Resolves #2222

What is being addressed

Airlock processor subnet was missing a route table.

How is this addressed

  • Add the route table to airlock processor subnet
  • Add the default nsg to the airlock notification subnet
  • Create subnets and assign nsg sequentially as parallel operations are not allowed and sometimes cause a failure.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6539a95.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara changed the title Tamirkamara/2097 airlock proc subnet route table Add route table to airlock processor subnet Aug 7, 2022
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2811914182 (with refid d4162cef)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Destroying branch test environment (RG: rg-tre1a06a6cd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2812246474)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Destroying PR test environment (RG: rg-tred4162cef)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2812246474)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Branch test environment destroy complete (RG: rg-tre1a06a6cd)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

PR test environment destroy complete (RG: rg-tred4162cef)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Destroying PR test environment (RG: rg-tred4162cef)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2812306282)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

PR test environment destroy complete (RG: rg-tred4162cef)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Destroying branch test environment (RG: rg-tre1a06a6cd)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2812306282)

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Branch test environment destroy complete (RG: rg-tre1a06a6cd)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2812338469 (with refid d4162cef)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review August 7, 2022 15:15
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2813163158 (with refid d4162cef)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2813163158 (with refid d4162cef)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2816803177 (with refid d4162cef)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit f61d9bb into main Aug 8, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2097-airlock-proc-subnet-route-table branch August 8, 2022 14:02
@marrobi marrobi mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatbal anatbal anatbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnotherOperationInProgress in Airlock Terraform Add network route to the airlock processor subnet
2 participants
@tamirkamara @anatbal