-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use delegated key when generating SAS token in API #2460
Conversation
Unit Test Results506 tests +503 504 ✔️ +504 14s ⏱️ - 19m 37s Results for commit 19d45ad. ± Comparison against base commit d996a70. This pull request removes 3 and adds 506 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
templates/workspaces/base/terraform/airlock/storage_accounts.tf
Outdated
Show resolved
Hide resolved
/test-destroy-env |
Destroying PR test environment (RG: rg-tred6ce07d6)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2859557449) |
Destroying branch test environment (RG: rg-tred7f431d0)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2859557449) |
Branch test environment destroy complete (RG: rg-tred7f431d0) |
PR test environment destroy complete (RG: rg-tred6ce07d6) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2859691130 (with refid (in response to this comment from @LizaShak) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2860817073 (with refid (in response to this comment from @LizaShak) |
1 similar comment
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2860817073 (with refid (in response to this comment from @LizaShak) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2866563969 (with refid (in response to this comment from @LizaShak) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2866630962 (with refid (in response to this comment from @LizaShak) |
Fixes #2390
What is being addressed
Use user delegated key when generating SAS token for airlock request in the API
How is this addressed