Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySql workspace service #2476

Merged
merged 15 commits into from
Aug 18, 2022
Merged

MySql workspace service #2476

merged 15 commits into from
Aug 18, 2022

Conversation

anatbal
Copy link
Contributor

@anatbal anatbal commented Aug 17, 2022

Fixes #1844

What is being addressed

An implementation of mysql workspace service

anatbal and others added 10 commits July 25, 2022 08:51
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited
Loading

Unit Test Results

0 tests   - 16   0 ✔️  - 16   0s ⏱️ -5s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ❌ ±  0 

Results for commit ec2462b. ± Comparison against base commit b8d3b7c.

♻️ This comment has been updated with latest results.

@anatbal anatbal marked this pull request as ready for review August 17, 2022 17:03
@anatbal anatbal requested a review from tamirkamara August 17, 2022 17:03
@anatbal anatbal assigned marrobi and unassigned marrobi Aug 17, 2022
@anatbal anatbal requested a review from marrobi August 17, 2022 17:03
@anatbal anatbal force-pushed the feature/sql-workspace-service branch from 183eeae to 45bd83e Compare August 17, 2022 17:14
@anatbal anatbal force-pushed the feature/sql-workspace-service branch from 45bd83e to 25b4d57 Compare August 17, 2022 17:26
@anatbal anatbal force-pushed the feature/sql-workspace-service branch from 4168956 to f24c04e Compare August 17, 2022 17:38
@anatbal anatbal enabled auto-merge (squash) August 17, 2022 17:58
tamirkamara
tamirkamara requested changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing tags on the new resources you've created.

CHANGELOG.md Outdated Show resolved Hide resolved
templates/workspace_services/sql/terraform/main.tf Outdated Show resolved Hide resolved
templates/workspace_services/sql/terraform/mysql.tf Outdated Show resolved Hide resolved
@anatbal anatbal requested a review from tamirkamara August 18, 2022 10:04
@anatbal
Copy link
Contributor Author

anatbal commented Aug 18, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2881602557 (with refid 9b95a99d)

(in response to this comment from @anatbal)

@tamirkamara tamirkamara disabled auto-merge August 18, 2022 10:06
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2881602557 (with refid 9b95a99d)

(in response to this comment from @anatbal)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2881602557 (with refid 9b95a99d)

(in response to this comment from @anatbal)

@tamirkamara
Copy link
Collaborator

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2882220776 (with refid 9b95a99d)

(in response to this comment from @tamirkamara)

@anatbal
Copy link
Contributor Author

anatbal commented Aug 18, 2022

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2882443231 (with refid 9b95a99d)

(in response to this comment from @anatbal)

@tamirkamara tamirkamara merged commit f6d0ac2 into microsoft:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

@marrobi marrobi Awaiting requested review from marrobi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySql workspace service
3 participants
@anatbal @tamirkamara @marrobi